Fix regression on route paths with colons #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fm/route-colons
branch
from
c0093cf
to
4cad3eb
Compare
florimondmanca
changed the title
florimondmanca
changed the title
|
We can add a co-author when squashing for the original author. That's what I usually do, but act as you like. 🙏 |
|
I can add @bodograumann as a co-author then. :) |
Merged
|
Thanks for merging this fix. I'm really happy this project is so active! |
|
Thank you for bringing a solution right away! 🎉 This will be available on Starlette 0.20.2, which is going to be released today. JFYK :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tiangolo/fastapi#4892 which was introduced in 0.18.0 via #1322.
Narrower alternative to #1657, that also reorganizes tests introduced by #1322 so that the "'Host' header matching should ignore ports" behavior is clearer.
(Matching when host string and requested
Hosthave the exact same:portis the intuitive case. What's special is Starlette matches even in case of absent or different port inHost.)